vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: validate social login key JSON fields (#33622)

Browse source 
Any misconfiguration would break login page otherwise

Resolves #33579

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-08-14 12:56:12 +05:30 • committed by GitHub
parent 4acd07eaa4
commit debd500cf3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/integrations/doctype/social_login_key/social_login_key.py
View file

@ -89,6 +89,17 @@ class SocialLoginKey(Document):
frappe.throw(
_("Please enter Client Secret before social login is enabled"), exc=ClientSecretNotSetError
)
if self.auth_url_data:
try:
json.loads(self.auth_url_data)
except json.JSONDecodeError:
frappe.throw(_("Auth URL data should be valid JSON"))
if self.api_endpoint_args:
try:
json.loads(self.api_endpoint_args)
except json.JSONDecodeError:
frappe.throw(_("API Endpoint Args should be valid JSON"))
def set_icon(self):
icon_map = {