From df0c96eba3adcff287f267da6b02dc63d24bc28c Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 19 Jun 2020 11:30:32 +0000 Subject: [PATCH] fix: sidebar item reference bug breaking addClass and removeClass (#10744) --- frappe/public/js/frappe/views/desktop/desktop.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/views/desktop/desktop.js b/frappe/public/js/frappe/views/desktop/desktop.js index 7b1645fc41..acc49c79a4 100644 --- a/frappe/public/js/frappe/views/desktop/desktop.js +++ b/frappe/public/js/frappe/views/desktop/desktop.js @@ -3,6 +3,7 @@ export default class Desktop { this.wrapper = wrapper; this.pages = {}; this.sidebar_items = {}; + this.mobile_sidebar_items = {}; this.sidebar_categories = [ "Modules", "Domains", @@ -84,10 +85,13 @@ export default class Desktop { this.current_page = item.name; } let $item = get_sidebar_item(item); - - $item.appendTo(this.mobile_list); - $item.clone().appendTo(this.sidebar); + let $mobile_item = $item.clone(); + + $item.appendTo(this.sidebar); this.sidebar_items[item.name] = $item; + + $mobile_item.appendTo(this.mobile_list); + this.mobile_sidebar_items[item.name] = $mobile_item; }; const make_category_title = name => { @@ -122,7 +126,10 @@ export default class Desktop { if (this.sidebar_items && this.sidebar_items[this.current_page]) { this.sidebar_items[this.current_page].removeClass("selected"); + this.mobile_sidebar_items[this.current_page].removeClass("selected"); + this.sidebar_items[page].addClass("selected"); + this.mobile_sidebar_items[page].addClass("selected"); } this.current_page = page; this.mobile_list.hide();