vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: ~90% faster frappe.get_cached_doc (#17107)

Browse source
This commit is contained in:
Sagar Vora 2022-06-08 10:19:11 +00:00 • committed by GitHub
parent 6f6ded256f
commit df28f32b8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frappe/__init__.py
View file

@ -1040,15 +1040,21 @@ def get_cached_doc(*args, **kwargs):
if doc := cache().hget("document_cache", key):
return _respond(doc, True)
# Not found in local/redis, fetch from DB and store in cache
# Not found in local/redis, fetch from DB
doc = get_doc(*args, **kwargs)
# Store in redis cache
key = get_document_cache_key(doc.doctype, doc.name)
# Store in cache
if not key:
key = get_document_cache_key(doc.doctype, doc.name)
local.document_cache[key] = doc
# Avoid setting in local.cache since there's separate cache
cache().hset("document_cache", key, doc.as_dict(), cache_locally=False)
# Avoid setting in local.cache since we're already using local.document_cache above
# Try pickling the doc object as-is first, else fallback to doc.as_dict()
try:
cache().hset("document_cache", key, doc, cache_locally=False)
except Exception:
cache().hset("document_cache", key, doc.as_dict(), cache_locally=False)
return doc
@ -1124,6 +1130,7 @@ def get_doc(*args, **kwargs):
if key := can_cache_doc(args):
if key in local.document_cache:
local.document_cache[key] = doc
if cache().hexists("document_cache", key):
cache().hset("document_cache", key, doc.as_dict())

4
frappe/utils/redis_wrapper.py
View file

@ -159,9 +159,7 @@ class RedisWrapper(redis.Redis):
# set in local
if cache_locally:
if _name not in frappe.local.cache:
frappe.local.cache[_name] = {}
frappe.local.cache[_name][key] = value
frappe.local.cache.setdefault(_name, {})[key] = value
# set in redis
try: