From dfedd584ca8622da7fbc539fb76c7121944a4350 Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Wed, 9 Aug 2017 12:55:15 +0530 Subject: [PATCH] Explicitly convert dict.values() to list --- frappe/model/base_document.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py index 0151feac8e..5ba5ceea6f 100644 --- a/frappe/model/base_document.py +++ b/frappe/model/base_document.py @@ -296,7 +296,7 @@ class BaseDocument(object): doctype = self.doctype, columns = ", ".join(["`"+c+"`" for c in columns]), values = ", ".join(["%s"] * len(columns)) - ), d.values()) + ), list(d.values())) except Exception as e: if e.args[0]==1062: if "PRIMARY" in cstr(e.args[1]): @@ -338,7 +338,7 @@ class BaseDocument(object): set {values} where name=%s""".format( doctype = self.doctype, values = ", ".join(["`"+c+"`=%s" for c in columns]) - ), d.values() + [name]) + ), list(d.values()) + [name]) except Exception as e: if e.args[0]==1062 and "Duplicate" in cstr(e.args[1]): self.show_unique_validation_message(e)