From e01b6ff4ec64bf64e34f3e956825c09eb814d521 Mon Sep 17 00:00:00 2001
From: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
Date: Fri, 27 Jun 2025 14:35:34 +0530
Subject: [PATCH] test: improve report custom permission test

---
 frappe/core/doctype/report/test_report.py | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/frappe/core/doctype/report/test_report.py b/frappe/core/doctype/report/test_report.py
index ef606d00cf..29b22b1799 100644
--- a/frappe/core/doctype/report/test_report.py
+++ b/frappe/core/doctype/report/test_report.py
@@ -200,9 +200,10 @@ class TestReport(IntegrationTestCase):
 			self.assertNotEqual(report.is_permitted(), True)
 
 	def test_report_custom_permissions(self):
-		frappe.set_user("test@example.com")
+		# delete custom role if exists
 		frappe.db.delete("Custom Role", {"report": "Test Custom Role Report"})
-		frappe.db.commit()  # nosemgrep
+
+		# create report if not exists
 		if not frappe.db.exists("Report", "Test Custom Role Report"):
 			report = frappe.get_doc(
 				{
@@ -217,8 +218,11 @@ class TestReport(IntegrationTestCase):
 		else:
 			report = frappe.get_doc("Report", "Test Custom Role Report")
 
-		self.assertEqual(report.is_permitted(), True)
+		# check report is permitted without custom role created
+		with self.set_user("test@example.com"):
+			self.assertEqual(report.is_permitted(), True)
 
+		# create custom role for report
 		frappe.get_doc(
 			{
 				"doctype": "Custom Role",
@@ -228,8 +232,9 @@ class TestReport(IntegrationTestCase):
 			}
 		).insert(ignore_permissions=True)
 
-		self.assertNotEqual(report.is_permitted(), True)
-		frappe.set_user("Administrator")
+		# check report is not permitted with custom role created
+		with self.set_user("test@example.com"):
+			self.assertNotEqual(report.is_permitted(), True)
 
 	# test for the `_format` method if report data doesn't have sort_by parameter
 	def test_format_method(self):