vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: remove items linked to non-existing doctypes from portal settings (#22417)

Browse source 
* fix: remove non-existing ref doctypes from portal settings

* fix: use separate list to iterate
This commit is contained in:
Gursheen Kaur Anand 2023-09-15 15:06:51 +05:30 • committed by GitHub
parent 87c1a9d7d7
commit e03525efba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/website/doctype/portal_settings/portal_settings.py
View file

@ -49,6 +49,7 @@ class PortalSettings(Document):
dirty = True
if dirty:
self.remove_deleted_doctype_items()
self.save()
def on_update(self):
@ -65,3 +66,9 @@ class PortalSettings(Document):
# clears role based home pages
frappe.clear_cache()
def remove_deleted_doctype_items(self):
existing_doctypes = set(frappe.get_list("DocType", pluck="name"))
for menu_item in list(self.get("menu")):
if menu_item.reference_doctype not in existing_doctypes:
self.remove(menu_item)