From e0e69a495c7a2640ae781c2f24cd80e4d110457c Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Fri, 9 Jan 2026 19:37:08 +0530 Subject: [PATCH] fix: force download files based on extension even on development server Signed-off-by: Akhil Narang --- frappe/middlewares.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/frappe/middlewares.py b/frappe/middlewares.py index 1898734917..76feb5f96b 100644 --- a/frappe/middlewares.py +++ b/frappe/middlewares.py @@ -8,12 +8,27 @@ from werkzeug.middleware.shared_data import SharedDataMiddleware import frappe from frappe.utils import cstr, get_site_name +from frappe.utils.response import FORCE_DOWNLOAD_EXTENSIONS class StaticDataMiddleware(SharedDataMiddleware): def __call__(self, environ, start_response): self.environ = environ - return super().__call__(environ, start_response) + + def patch_start_response(status, headers, exc_info=None): + if ( + (path := environ.get("PATH_INFO", "")) + and path.startswith("/files/") + and path.lower().endswith(FORCE_DOWNLOAD_EXTENSIONS) + ): + from urllib.parse import quote + + filename = Path(path).name + headers.append(("Content-Disposition", f"attachment; filename*=UTF-8''{quote(filename)}")) + + return start_response(status, headers, exc_info) + + return super().__call__(environ, patch_start_response) def get_directory_loader(self, directory): def loader(path):