vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(oauth): add exp to idToken (#20694)

Browse source
This commit is contained in:
William Luke 2023-05-04 22:49:03 +03:00 • committed by GitHub
parent f5ba787f4b
commit e0ed7d3b97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/oauth.py
View file

@ -331,6 +331,8 @@ class OAuthWebRequestValidator(RequestValidator):
userinfo = get_userinfo(user)
id_token["exp"] = id_token.get("iat") + token.get("expires_in")
if userinfo.get("iss"):
id_token["iss"] = userinfo.get("iss")
@ -363,6 +365,7 @@ class OAuthWebRequestValidator(RequestValidator):
def get_jwt_bearer_token(self, token, token_handler, request):
now = datetime.datetime.now()
id_token = dict(
aud=token.client_id,
iat=round(now.timestamp()),

1
frappe/tests/test_oauth20.py
View file

@ -367,6 +367,7 @@ class TestOAuth20(FrappeRequestTestCase):
audience=self.client_id,
key=self.client_secret,
algorithms=["HS256"],
options={"verify_signature": True, "require": ["exp", "iat", "aud"]},
)