From e355a175d842d6294db87f01b13298b443753747 Mon Sep 17 00:00:00 2001
From: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
Date: Wed, 18 Jun 2025 01:33:11 +0000
Subject: [PATCH] fix: always defer access log insertion (#32976)

---
 frappe/core/doctype/access_log/access_log.py | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/frappe/core/doctype/access_log/access_log.py b/frappe/core/doctype/access_log/access_log.py
index 5c939587b4..19082c96b7 100644
--- a/frappe/core/doctype/access_log/access_log.py
+++ b/frappe/core/doctype/access_log/access_log.py
@@ -54,13 +54,10 @@ def make_access_log(
 	page=None,
 	columns=None,
 ):
-	user = frappe.session.user
-	in_request = frappe.request and frappe.request.method == "GET"
-
 	access_log = frappe.get_doc(
 		{
 			"doctype": "Access Log",
-			"user": user,
+			"user": frappe.session.user,
 			"export_from": doctype,
 			"reference_document": document,
 			"file_type": file_type,
@@ -72,18 +69,11 @@ def make_access_log(
 		}
 	)
 
-	if frappe.flags.read_only:
+	if not frappe.in_test:
 		access_log.deferred_insert()
-		return
 	else:
 		access_log.db_insert()
 
-	# `frappe.db.commit` added because insert doesnt `commit` when called in GET requests like `printview`
-	# dont commit in test mode. It must be tempting to put this block along with the in_request in the
-	# whitelisted method...yeah, don't do it. That part would be executed possibly on a read only DB conn
-	if not frappe.in_test or in_request:
-		frappe.db.commit()
-
 
 # only for backward compatibility
 _make_access_log = make_access_log