From 448c2f4e3f388ffdddb3928a2838b572d2de6c23 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Mon, 13 Jul 2020 22:05:54 +0530 Subject: [PATCH 1/2] fix(patch): Ignore cancelled ToDos while setting _assign --- frappe/patches/v12_0/set_correct_assign_value_in_docs.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/patches/v12_0/set_correct_assign_value_in_docs.py b/frappe/patches/v12_0/set_correct_assign_value_in_docs.py index d3f97af50b..65a635c170 100644 --- a/frappe/patches/v12_0/set_correct_assign_value_in_docs.py +++ b/frappe/patches/v12_0/set_correct_assign_value_in_docs.py @@ -9,8 +9,9 @@ def execute(): FROM `tabToDo` WHERE - COALESCE(reference_type, '') != '' and - COALESCE(reference_name, '') != '' + COALESCE(reference_type, '') != '' AND + COALESCE(reference_name, '') != '' AND + status != 'Cancelled' GROUP BY reference_type, reference_name ''' From 21277403a741d5ddabf9144f64f29af347d9ed69 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Mon, 13 Jul 2020 22:11:15 +0530 Subject: [PATCH 2/2] fix: Re-run fixed patch --- frappe/patches.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/patches.txt b/frappe/patches.txt index cfcbc1ceba..dce4187695 100644 --- a/frappe/patches.txt +++ b/frappe/patches.txt @@ -264,7 +264,7 @@ frappe.patches.v11_0.make_all_prepared_report_attachments_private #2019-11-26 frappe.patches.v12_0.setup_email_linking frappe.patches.v12_0.fix_home_settings_for_all_users frappe.patches.v12_0.change_existing_dashboard_chart_filters -frappe.patches.v12_0.set_correct_assign_value_in_docs +frappe.patches.v12_0.set_correct_assign_value_in_docs #2020-07-13 execute:frappe.delete_doc("Test Runner") execute:frappe.delete_doc_if_exists('DocType', 'Google Maps Settings') execute:frappe.db.set_default('desktop:home_page', 'workspace')