From 195efff9f19e03f1860113d5c96afc29bf9af811 Mon Sep 17 00:00:00 2001
From: mahsem <137205921+mahsem@users.noreply.github.com>
Date: Tue, 24 Dec 2024 19:11:12 +0100
Subject: [PATCH 1/3] fix: remove_plural_from _modal

---
 frappe/public/js/frappe/form/multi_select_dialog.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/form/multi_select_dialog.js b/frappe/public/js/frappe/form/multi_select_dialog.js
index 3c448e521b..65084fb60f 100644
--- a/frappe/public/js/frappe/form/multi_select_dialog.js
+++ b/frappe/public/js/frappe/form/multi_select_dialog.js
@@ -77,7 +77,7 @@ frappe.ui.form.MultiSelectDialog = class MultiSelectDialog {
 	}
 
 	make() {
-		let doctype_plural = __(this.doctype).plural();
+		let doctype_plural = __(this.doctype);
 		let title = __("Select {0}", [this.for_select ? __("value") : doctype_plural]);
 
 		this.dialog = new frappe.ui.Dialog({

From 0cdef9ce1e3197e080c9fca54139f705c998429c Mon Sep 17 00:00:00 2001
From: mahsem <137205921+mahsem@users.noreply.github.com>
Date: Sun, 29 Dec 2024 20:17:20 +0100
Subject: [PATCH 2/3] fix: cleanup remaining variable

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
---
 frappe/public/js/frappe/form/multi_select_dialog.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/frappe/public/js/frappe/form/multi_select_dialog.js b/frappe/public/js/frappe/form/multi_select_dialog.js
index 65084fb60f..d02ad0974c 100644
--- a/frappe/public/js/frappe/form/multi_select_dialog.js
+++ b/frappe/public/js/frappe/form/multi_select_dialog.js
@@ -77,8 +77,7 @@ frappe.ui.form.MultiSelectDialog = class MultiSelectDialog {
 	}
 
 	make() {
-		let doctype_plural = __(this.doctype);
-		let title = __("Select {0}", [this.for_select ? __("value") : doctype_plural]);
+		let title = __("Select {0}", [this.for_select ? __("value") : __(this.doctype)]);
 
 		this.dialog = new frappe.ui.Dialog({
 			title: title,

From b3ab2e60c48135a1665257e68669ca0b562b59c4 Mon Sep 17 00:00:00 2001
From: mahsem <137205921+mahsem@users.noreply.github.com>
Date: Wed, 1 Jan 2025 17:47:45 +0100
Subject: [PATCH 3/3] fix: multi_select_dialog_failing_test

---
 cypress/integration/multi_select_dialog.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cypress/integration/multi_select_dialog.js b/cypress/integration/multi_select_dialog.js
index 7b30ad8c85..abf6604bec 100644
--- a/cypress/integration/multi_select_dialog.js
+++ b/cypress/integration/multi_select_dialog.js
@@ -41,7 +41,7 @@ context("MultiSelectDialog", () => {
 
 	it("checks multi select dialog api works", () => {
 		open_multi_select_dialog();
-		cy.get_open_dialog().should("contain", "Select Contacts");
+		cy.get_open_dialog().should("contain", "Select Contact");
 	});
 
 	it("checks for filters", () => {