From e8155de02223cbee5c6cb43273088d5effa31560 Mon Sep 17 00:00:00 2001 From: sokumon Date: Thu, 22 Jan 2026 14:10:10 +0530 Subject: [PATCH] fix: dont show active element when sidebar is collpased --- frappe/public/js/frappe/ui/sidebar/sidebar.js | 2 +- frappe/public/js/frappe/ui/sidebar/sidebar_item.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar.js b/frappe/public/js/frappe/ui/sidebar/sidebar.js index 98b501ad02..51bdb31ab2 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar.js @@ -175,7 +175,7 @@ frappe.ui.Sidebar = class Sidebar { if (active_section) { let section = this.get_item(active_section); if (section) { - if (section.collapsed) { + if (this.sidebar_expanded && section.collapsed) { section.open(); } } diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js index f669d658ff..760b81e193 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js @@ -180,9 +180,9 @@ frappe.ui.sidebar_item.TypeSectionBreak = class SectionBreakSidebarItem extends super.make(); if (!this.item.nested_items || this.item.nested_items.length == 0) return; this.add_items(); + $(this.container).append(this.full_template); this.toggle_on_collapse(); this.enable_collapsible(this.item, this.full_template); - $(this.container).append(this.full_template); } open() { this.collapsed = false; @@ -265,7 +265,7 @@ frappe.ui.sidebar_item.TypeSectionBreak = class SectionBreakSidebarItem extends const me = this; let current_sidebar_state = this.section_breaks_state[this.workspace_title]; for (const [element_name, collapsed] of Object.entries(current_sidebar_state)) { - if ($(this.wrapper).attr("item-name") == element_name) { + if ($(this.wrapper).attr("title") == element_name) { me.collapsed = collapsed; me.toggle(); }