From 62b48aeca4306c28c45912854a10932b37c159a4 Mon Sep 17 00:00:00 2001 From: prssanna Date: Mon, 6 Apr 2020 17:52:44 +0530 Subject: [PATCH 1/2] fix: remove field if no docfield exists --- frappe/public/js/frappe/list/list_sidebar_group_by.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/list/list_sidebar_group_by.js b/frappe/public/js/frappe/list/list_sidebar_group_by.js index bd37b71ae4..f72ff33e4c 100644 --- a/frappe/public/js/frappe/list/list_sidebar_group_by.js +++ b/frappe/public/js/frappe/list/list_sidebar_group_by.js @@ -53,14 +53,17 @@ frappe.views.ListGroupBy = class ListGroupBy { render_group_by_items() { let get_item_html = (fieldname) => { - let label; - let fieldtype; + let label, fieldtype; if (fieldname === 'assigned_to') { label = __('Assigned To'); } else if (fieldname === 'owner') { label = __('Created By'); } else { label = frappe.meta.get_label(this.doctype, fieldname); + let docfield = frappe.meta.get_docfield(this.doctype, fieldname); + if (!docfield) { + return; + } fieldtype = frappe.meta.get_docfield(this.doctype, fieldname).fieldtype; } From d7dc9bf64e3ea963a64ad6f8ecff0464c910774f Mon Sep 17 00:00:00 2001 From: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Date: Thu, 9 Apr 2020 20:11:02 +0530 Subject: [PATCH 2/2] refactor: Remove redundant code --- frappe/public/js/frappe/list/list_sidebar_group_by.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/list/list_sidebar_group_by.js b/frappe/public/js/frappe/list/list_sidebar_group_by.js index f72ff33e4c..7aa62dcb5f 100644 --- a/frappe/public/js/frappe/list/list_sidebar_group_by.js +++ b/frappe/public/js/frappe/list/list_sidebar_group_by.js @@ -64,7 +64,7 @@ frappe.views.ListGroupBy = class ListGroupBy { if (!docfield) { return; } - fieldtype = frappe.meta.get_docfield(this.doctype, fieldname).fieldtype; + fieldtype = docfield.fieldtype; } return `