vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat: add validation to prevent changing values on save

Browse source
This commit is contained in:
Ejaaz Khan 2025-09-19 11:21:40 +05:30
parent d80e41cca3
commit e69b607aab
3 changed files with 34 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
frappe/model/base_document.py
View file

@ -1399,7 +1399,7 @@ class BaseDocument:
else:
return True
def reset_values_if_no_permlevel_access(self, has_access_to, high_permlevel_fields):
def reset_values_if_no_permlevel_access(self, has_access_to, high_permlevel_fields, mask_fields):
"""If the user does not have permissions at permlevel > 0, then reset the values to original / default"""
to_reset = [
df
@ -1411,22 +1411,35 @@ class BaseDocument:
)
]
if to_reset:
if self.is_new():
# if new, set default value
ref_doc = frappe.new_doc(self.doctype)
else:
# get values from old doc
if self.parent_doc:
parent_doc = self.parent_doc.get_latest()
child_docs = [d for d in parent_doc.get(self.parentfield) if d.name == self.name]
if not child_docs:
return
ref_doc = child_docs[0]
else:
ref_doc = self.get_latest()
to_reset = to_reset + mask_fields
for df in to_reset:
if not to_reset:
return
if self.is_new():
# if new, set default value
ref_doc = frappe.new_doc(self.doctype)
else:
# get values from old doc
if self.parent_doc:
parent_doc = self.parent_doc.get_latest()
child_docs = [d for d in parent_doc.get(self.parentfield) if d.name == self.name]
if not child_docs:
return
ref_doc = child_docs[0]
else:
ref_doc = self.get_latest()
masked_fieldnames = [df.fieldname for df in to_reset if df.get("mask_readonly")]
ref_values = {}
if not self.is_new() and masked_fieldnames:
ref_values = frappe.db.get_value(self.doctype, self.name, masked_fieldnames, as_dict=True) or {}
for df in to_reset:
if df.get("mask_readonly") and not self.is_new():
if df.fieldname in ref_values:
self.set(df.fieldname, ref_values[df.fieldname])
else:
self.set(df.fieldname, ref_doc.get(df.fieldname))
def get_value(self, fieldname):

6
frappe/model/document.py
View file

@ -923,8 +923,10 @@ class Document(BaseDocument):
has_access_to = self.get_permlevel_access()
high_permlevel_fields = self.meta.get_high_permlevel_fields()
if high_permlevel_fields:
self.reset_values_if_no_permlevel_access(has_access_to, high_permlevel_fields)
mask_fields = self.meta.get_masked_fields()
if high_permlevel_fields or mask_fields:
self.reset_values_if_no_permlevel_access(has_access_to, high_permlevel_fields, mask_fields)
# If new record then don't reset the values for child table
if self.is_new():

4
frappe/public/js/frappe/form/form.js
View file

@ -465,9 +465,7 @@ frappe.ui.form.Form = class FrappeForm {
this.show_conflict_message();
this.show_submission_queue_banner();
if (!this.is_new()) {
this.mark_mask_fields_readonly();
}
this.mark_mask_fields_readonly();
if (frappe.boot.read_only) {
this.disable_form();