diff --git a/frappe/core/doctype/feedback/test_feedback.py b/frappe/core/doctype/feedback/test_feedback.py index 31e5d751e7..702f9d8ac1 100644 --- a/frappe/core/doctype/feedback/test_feedback.py +++ b/frappe/core/doctype/feedback/test_feedback.py @@ -1,8 +1,27 @@ # Copyright (c) 2021, Frappe Technologies and Contributors # See license.txt -# import frappe +import frappe import unittest class TestFeedback(unittest.TestCase): - pass + def test_feedback_creation_updation(self): + from frappe.website.doctype.blog_post.test_blog_post import make_test_blog + test_blog = make_test_blog() + + frappe.db.sql("delete from `tabFeedback` where reference_doctype = 'Blog Post'") + + from frappe.templates.includes.feedback.feedback import add_feedback, update_feedback + feedback = add_feedback('Blog Post', test_blog.name, 5, 'New feedback','test@test.com') + + self.assertEqual(feedback.feedback, 'New feedback') + self.assertEqual(feedback.rating, 5) + + updated_feedback = update_feedback('Blog Post', test_blog.name, 6, 'Updated feedback', 'test@test.com') + + self.assertEqual(updated_feedback.feedback, 'Updated feedback') + self.assertEqual(updated_feedback.rating, 6) + + frappe.db.sql("delete from `tabFeedback` where reference_doctype = 'Blog Post'") + + test_blog.delete() \ No newline at end of file diff --git a/frappe/templates/includes/feedback/feedback.py b/frappe/templates/includes/feedback/feedback.py index 23a61b8885..c0bdea9a27 100644 --- a/frappe/templates/includes/feedback/feedback.py +++ b/frappe/templates/includes/feedback/feedback.py @@ -18,6 +18,7 @@ def add_feedback(reference_doctype, reference_name, rating, feedback, feedback_e subject = _('New Feedback on {0}: {1}').format(reference_doctype, reference_name) send_mail(doc, subject) + return doc @frappe.whitelist() def update_feedback(reference_doctype, reference_name, rating, feedback, feedback_email): @@ -34,6 +35,7 @@ def update_feedback(reference_doctype, reference_name, rating, feedback, feedbac subject = _('Feedback updated on {0}: {1}').format(reference_doctype, reference_name) send_mail(doc, subject) + return doc def send_mail(feedback, subject): doc = frappe.get_doc(feedback.reference_doctype, feedback.reference_name)