From e88b5f6a85410aa6a13cf99c3c922e9987df4ee5 Mon Sep 17 00:00:00 2001
From: Rushabh Mehta <rmehta@gmail.com>
Date: Thu, 14 Jan 2021 09:49:44 +0530
Subject: [PATCH] fix(minor): keep form dashboard sections expanded by default

---
 frappe/public/js/frappe/form/dashboard.js | 13 ++++++++++---
 frappe/public/scss/desk/form.scss         |  2 +-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/frappe/public/js/frappe/form/dashboard.js b/frappe/public/js/frappe/form/dashboard.js
index 638d0090d6..4dca1e4daf 100644
--- a/frappe/public/js/frappe/form/dashboard.js
+++ b/frappe/public/js/frappe/form/dashboard.js
@@ -602,7 +602,7 @@ class Section {
 		this.df = options || {};
 		this.make();
 
-		if (this.df.title && this.df.collapsible) {
+		if (this.df.title && this.df.collapsible && localStorage.getItem(options.css_class + '-closed')) {
 			this.collapse();
 		}
 		this.refresh();
@@ -657,6 +657,7 @@ class Section {
 			this.collapse_link = this.head.on("click", () => {
 				this.collapse();
 			});
+			this.set_icon();
 			this.indicator.show();
 		}
 	}
@@ -677,9 +678,15 @@ class Section {
 		this.body.toggleClass("hide", hide);
 		this.head && this.head.toggleClass("collapsed", hide);
 
-		let indicator_icon = hide ? 'down' : 'up-line';
+		this.set_icon(hide);
 
-		this.indicator & this.indicator.html(frappe.utils.icon(indicator_icon, 'sm', 'mb-1'));
+		// save state for next reload ('' is falsy)
+		localStorage.setItem(this.df.css_class + '-closed', hide ? '1' : '');	
+	}
+
+	set_icon(hide) {
+		let indicator_icon = hide ? 'down' : 'up-line';
+		this.indicator && this.indicator.html(frappe.utils.icon(indicator_icon, 'sm', 'mb-1'));
 	}
 
 	is_collapsed() {
diff --git a/frappe/public/scss/desk/form.scss b/frappe/public/scss/desk/form.scss
index 66c7e531cb..ee8a618ff7 100644
--- a/frappe/public/scss/desk/form.scss
+++ b/frappe/public/scss/desk/form.scss
@@ -24,7 +24,7 @@
 			color: $text-muted;
 			margin-left: 10px;
 			position: relative;
-			bottom: -1px;
+			padding: 0px;
 		}
 
 		.collapse-indicator.octicon-chevron-up {