From e964c11cd66969af1a28d89ecc3adaf19b5b5ff5 Mon Sep 17 00:00:00 2001 From: David Arnold Date: Fri, 22 Nov 2024 23:45:04 +0100 Subject: [PATCH] fix: don't show deprecation on a effective no-op (#28552) --- frappe/parallel_test_runner.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/frappe/parallel_test_runner.py b/frappe/parallel_test_runner.py index 2f832045b8..018c576ada 100644 --- a/frappe/parallel_test_runner.py +++ b/frappe/parallel_test_runner.py @@ -85,14 +85,15 @@ class ParallelTestRunner: print("running tests from", "/".join(file_info)) return - from frappe.deprecation_dumpster import deprecation_warning + if frappe.session.user != "Administrator": + from frappe.deprecation_dumpster import deprecation_warning - deprecation_warning( - "2024-11-13", - "v17", - "Setting the test environment user to 'Administrator' by the test runner is deprecated. The UnitTestCase now ensures a consistent user environment on set up and tear down at the class level. ", - ) - frappe.set_user("Administrator") + deprecation_warning( + "2024-11-13", + "v17", + "Setting the test environment user to 'Administrator' by the test runner is deprecated. The UnitTestCase now ensures a consistent user environment on set up and tear down at the class level. ", + ) + frappe.set_user("Administrator") path, filename = file_info module = self.get_module(path, filename) from frappe.deprecation_dumpster import compat_preload_test_records_upfront