From da1e8750c8f402a47afb9db90e04f07fa1454a80 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Sun, 10 Mar 2024 16:09:09 +0100
Subject: [PATCH] refactor: replace `in_list(array, member)` with
 `array.includes(member)`

---
 .../print_format_builder/print_format_builder_field.html    | 2 +-
 .../print_format_builder/print_format_builder_sidebar.html  | 2 +-
 .../public/js/form_builder/components/FieldProperties.vue   | 4 ++--
 frappe/public/js/workflow_builder/components/Properties.vue | 6 +++---
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/frappe/printing/page/print_format_builder/print_format_builder_field.html b/frappe/printing/page/print_format_builder/print_format_builder_field.html
index 5e900df601..67bc4d3e53 100644
--- a/frappe/printing/page/print_format_builder/print_format_builder_field.html
+++ b/frappe/printing/page/print_format_builder/print_format_builder_field.html
@@ -10,7 +10,7 @@
 		data-columns="{%= me.get_visible_columns_string(field) %}"
 		data-doctype="{%= field.options %}"
 	{% } %}>
-	{% if !in_list(["Table", "HTML", "Custom HTML"], field.fieldtype) %}
+	{% if !["Table", "HTML", "Custom HTML"].includes(field.fieldtype) %}
 	<a class="field-settings pull-right">
 		<span>
 			<svg class="icon icon-sm"><use href="#icon-setting-gear"></use></svg>
diff --git a/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html b/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html
index 2b5b040bca..8ed4d50ddc 100644
--- a/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html
+++ b/frappe/printing/page/print_format_builder/print_format_builder_sidebar.html
@@ -4,7 +4,7 @@
 </div>
 <div class="print-format-builder-sidebar-fields">
 	{% for (var i=0, l=fields.length; i < l; i++) { var f = fields[i]; %}
-		{% if(!in_list(["Section Break", "Tab Break", "Column Break", "Fold"], f.fieldtype)) { %}
+		{% if(!["Section Break", "Tab Break", "Column Break", "Fold"].includes(f.fieldtype)) { %}
 		<div class="print-format-builder-field-placeholder"
 			data-fieldname="{%= f.fieldname %}">
 			<div title="{{f.label}}" class="field-label btn btn-default btn-sm sidebar-field ellipsis
diff --git a/frappe/public/js/form_builder/components/FieldProperties.vue b/frappe/public/js/form_builder/components/FieldProperties.vue
index 159d8eb43f..21f0dd861e 100644
--- a/frappe/public/js/form_builder/components/FieldProperties.vue
+++ b/frappe/public/js/form_builder/components/FieldProperties.vue
@@ -26,7 +26,7 @@ let docfield_df = computed(() => {
 		}
 
 		if (
-			in_list(["fetch_from", "fetch_if_empty"], df.fieldname) &&
+			["fetch_from", "fetch_if_empty"].includes(df.fieldname) &&
 			in_list(frappe.model.no_value_type, store.form.selected_field.fieldtype)
 		) {
 			return false;
@@ -41,7 +41,7 @@ let docfield_df = computed(() => {
 			df.options = "";
 			args.value = {};
 
-			if (in_list(["Table", "Link"], store.form.selected_field.fieldtype)) {
+			if (["Table", "Link"].includes(store.form.selected_field.fieldtype)) {
 				df.fieldtype = "Link";
 				df.options = "DocType";
 
diff --git a/frappe/public/js/workflow_builder/components/Properties.vue b/frappe/public/js/workflow_builder/components/Properties.vue
index f8a9fbe9fa..8167ab8299 100644
--- a/frappe/public/js/workflow_builder/components/Properties.vue
+++ b/frappe/public/js/workflow_builder/components/Properties.vue
@@ -18,13 +18,13 @@ let properties = computed(() => {
 	if (store.workflow.selected && "action" in store.workflow.selected.data) {
 		title.value = "Transition Properties";
 		return store.transitionfields.filter((df) =>
-			in_list(["action", "allowed", "allow_self_approval", "condition"], df.fieldname)
+			["action", "allowed", "allow_self_approval", "condition"].includes(df.fieldname)
 		);
 	} else if (store.workflow.selected && "state" in store.workflow.selected.data) {
 		title.value = "State Properties";
 		let allow_edit = store.statefields.find((df) => df.fieldname == "allow_edit");
 		store.statefields = store.statefields.filter(
-			(df) => !in_list(["allow_edit", "workflow_builder_id"], df.fieldname)
+			(df) => !["allow_edit", "workflow_builder_id"].includes(df.fieldname)
 		);
 		store.statefields.splice(2, 0, allow_edit);
 
@@ -41,7 +41,7 @@ let properties = computed(() => {
 	}
 	title.value = "Workflow Details";
 	return store.workflowfields.filter(
-		(df) => !in_list(["states", "transitions", "workflow_data", "workflow_name"], df.fieldname)
+		(df) => !["states", "transitions", "workflow_data", "workflow_name"].includes(df.fieldname)
 	);
 });
 </script>