From ea08418d7dbbb9a2b9306cd53c876e4f2e7dd286 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 17 Jan 2024 14:22:05 +0530 Subject: [PATCH] fix: ignore unique fieldname validation during migrate (#24413) This can be addressed later instead of failing a migrate --- frappe/core/doctype/doctype/doctype.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py index 73c9fda5dc..f71ed048cb 100644 --- a/frappe/core/doctype/doctype/doctype.py +++ b/frappe/core/doctype/doctype/doctype.py @@ -4,13 +4,10 @@ import copy import json import os - -# imports - standard imports import re import shutil from typing import TYPE_CHECKING, Union -# imports - module imports import frappe from frappe import _ from frappe.cache_manager import clear_controller_cache, clear_user_cache @@ -1614,7 +1611,6 @@ def validate_fields(meta): check_illegal_characters(d.fieldname) check_invalid_fieldnames(meta.get("name"), d.fieldname) - check_unique_fieldname(meta.get("name"), d.fieldname) check_fieldname_length(d.fieldname) check_hidden_and_mandatory(meta.get("name"), d) check_unique_and_text(meta.get("name"), d) @@ -1624,6 +1620,7 @@ def validate_fields(meta): validate_data_field_type(d) if not frappe.flags.in_migrate: + check_unique_fieldname(meta.get("name"), d.fieldname) check_link_table_options(meta.get("name"), d) check_illegal_mandatory(meta.get("name"), d) check_dynamic_link_options(d)