From ea8417acb025d604252dde1bf1e53e8dee86460e Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Mon, 4 Apr 2016 13:16:13 +0530 Subject: [PATCH] [fix] link selector value should allow for double-quotes in data-value --- frappe/public/js/frappe/form/link_selector.js | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/frappe/public/js/frappe/form/link_selector.js b/frappe/public/js/frappe/form/link_selector.js index 07abfeea13..4c4d0aaab3 100644 --- a/frappe/public/js/frappe/form/link_selector.js +++ b/frappe/public/js/frappe/form/link_selector.js @@ -76,7 +76,7 @@ frappe.ui.form.LinkSelector = Class.extend({ $.each(r.values, function(i, v) { var row = $(repl('\
\ %(values)s
\ ', { @@ -84,23 +84,25 @@ frappe.ui.form.LinkSelector = Class.extend({ values: v.splice(1).join(", ") })).appendTo(parent); - row.find("a").click(function() { - var value = $(this).attr("data-value"); - var $link = this; - if(me.target.is_grid) { - // set in grid - me.set_in_grid(value); - } else { - if(me.target.doctype) - me.target.parse_validate_and_set_in_model(value); - else { - me.target.set_input(value); - me.target.$input.trigger("change"); + row.find("a") + .attr('data-value', v[0]) + .click(function() { + var value = $(this).attr("data-value"); + var $link = this; + if(me.target.is_grid) { + // set in grid + me.set_in_grid(value); + } else { + if(me.target.doctype) + me.target.parse_validate_and_set_in_model(value); + else { + me.target.set_input(value); + me.target.$input.trigger("change"); + } + me.dialog.hide(); } - me.dialog.hide(); - } - return false; - }) + return false; + }); }) } else { $('
' + __("No Results")