vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(goal): Make sure history field contains a JSON dump

Browse source
This commit is contained in:
Gavin D'souza 2022-04-01 16:43:25 +05:30
parent 842a4b03a5
commit eaa332e901
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/utils/goal.py
View file

@ -7,7 +7,7 @@ import frappe
from frappe import _
from frappe.query_builder.functions import DateFormat, Function
from frappe.query_builder.utils import DocType
from frappe.utils.data import add_to_date, flt, now_datetime
from frappe.utils.data import add_to_date, cstr, flt, now_datetime
from frappe.utils.formatters import format_value
from contextlib import suppress
@ -86,11 +86,11 @@ def get_monthly_goal_graph_data(
history = doc.get(goal_history_field)
month_to_value_dict = None
if history:
if history and "{" in cstr(history):
with suppress(ValueError):
month_to_value_dict = frappe.parse_json(history)
if month_to_value_dict is None:
if month_to_value_dict is None: # nosemgrep
doc_filter = {}
with suppress(ValueError):
doc_filter = frappe.parse_json(filters or "{}")