From eb8da5fd59c9b60a1cc78eae8aa0eb89e8c7f7ce Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 7 May 2023 13:19:23 +0530 Subject: [PATCH] fix!: Correct resolution order for template page (#20927) Current resolution is confusing mess: 1. Evaluation is done in order of installed app, first install wins 2. Except frappe, frappe is treated as lowest priority. Following same principle of "last write wins" everywhere similar to previous PRs: - https://github.com/frappe/frappe/pull/17869 - https://github.com/frappe/frappe/pull/20648 - https://github.com/frappe/frappe/pull/19653 Closes https://github.com/frappe/frappe/issues/20377 --- frappe/website/page_renderers/template_page.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/website/page_renderers/template_page.py b/frappe/website/page_renderers/template_page.py index 84d376feb4..77e14a3803 100644 --- a/frappe/website/page_renderers/template_page.py +++ b/frappe/website/page_renderers/template_page.py @@ -50,7 +50,7 @@ class TemplatePage(BaseTemplatePage): and /templates/pages folders and sets path if match is found """ folders = get_start_folders() - for app in frappe.get_installed_apps(frappe_last=True): + for app in reversed(frappe.get_installed_apps()): app_path = frappe.get_app_path(app) for dirname in folders: