From ec1384dafef8f2df4c9f48311e8ad2eefe070b21 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Wed, 12 Dec 2018 13:23:05 +0530 Subject: [PATCH] Fix faulty check --- frappe/public/js/frappe/model/perm.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js index 613756226c..60ae89a3da 100644 --- a/frappe/public/js/frappe/model/perm.js +++ b/frappe/public/js/frappe/model/perm.js @@ -153,8 +153,10 @@ $.extend(frappe.perm, { $.each(fields_to_check, (i, df) => { const user_permissions_for_doctype = user_permissions[df.options]; // check if there are any user permission applicable for parent doctype - const has_user_permission = user_permissions_for_doctype.some(perm => !perm.applicable_for || perm.applicable_for === doctype); - if (user_permissions_for_doctype && has_user_permission) { + const has_user_permission = user_permissions_for_doctype ? user_permissions_for_doctype + .some(perm => !perm.applicable_for || perm.applicable_for === doctype) : false; + + if (has_user_permission) { rules[df.label] = []; user_permissions_for_doctype.map(permission => { if (!permission.applicable_for || permission.applicable_for === doctype) {