From ec27c448721fbc40554d9e049908694c3851683a Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Wed, 5 Feb 2025 11:59:13 +0530 Subject: [PATCH] fix: only add expression if truthy (Don't try to insert empty string) Breaks on some v15 sites Signed-off-by: Akhil Narang --- frappe/patches/v16_0/update_expression_series.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/patches/v16_0/update_expression_series.py b/frappe/patches/v16_0/update_expression_series.py index 73fd81d3d2..76f954b806 100644 --- a/frappe/patches/v16_0/update_expression_series.py +++ b/frappe/patches/v16_0/update_expression_series.py @@ -54,8 +54,8 @@ def execute(): for doc in docs: _doc = frappe.get_doc(doctype.name, doc.name) expr = doctype.autoname[7 : doctype.autoname.find("{#")] - key = BRACED_PARAMS_WORD_PATTERN.sub(get_param_value_for_word_match(_doc), expr) - uniq_exprs.add(key) + if key := BRACED_PARAMS_WORD_PATTERN.sub(get_param_value_for_word_match(_doc), expr): + uniq_exprs.add(key) current = (frappe.qb.from_(Series).select("*").where(Series.name == "")).run(as_dict=True) if current: