From ec6d71e86477dd2a85104d63eea629fa4e13bd53 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Mon, 28 Mar 2022 18:15:45 +0530 Subject: [PATCH] chore(handler): Added typing, removed unnecessary assignments --- frappe/handler.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/frappe/handler.py b/frappe/handler.py index b4ec077947..07c4843c8f 100644 --- a/frappe/handler.py +++ b/frappe/handler.py @@ -18,6 +18,7 @@ from frappe.utils.image import optimize_image from frappe.utils.response import build_response if TYPE_CHECKING: + from frappe.core.doctype.user.user import User from frappe.core.doctype.file.file import File @@ -155,7 +156,7 @@ def upload_file(): else: raise frappe.PermissionError else: - user = frappe.get_doc("User", frappe.session.user) + user: "User" = frappe.get_doc("User", frappe.session.user) ignore_permissions = False files = frappe.request.files @@ -200,7 +201,7 @@ def upload_file(): is_whitelisted(method) return method() else: - ret = frappe.get_doc({ + return frappe.get_doc({ "doctype": "File", "attached_to_doctype": doctype, "attached_to_name": docname, @@ -210,9 +211,7 @@ def upload_file(): "file_url": file_url, "is_private": cint(is_private), "content": content - }) - ret.save(ignore_permissions=ignore_permissions) - return ret + }).save(ignore_permissions=ignore_permissions) @frappe.whitelist(allow_guest=True)