From 4708979e0fa93d2b71e9fbcbb12403fdd2a35ed6 Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Thu, 28 Sep 2023 11:08:11 +0200 Subject: [PATCH 1/3] refactor: use translation context for Edit button in Grid Row --- frappe/public/js/frappe/form/grid_row.js | 2 +- frappe/translations/fr.csv | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js index 02afd301d6..505ac24c8b 100644 --- a/frappe/public/js/frappe/form/grid_row.js +++ b/frappe/public/js/frappe/form/grid_row.js @@ -338,7 +338,7 @@ export default class GridRow { this.open_form_button = $(`
${frappe.utils.icon("edit", "xs")} -
${__("Edit")}
+
${__("Edit", "", "edit-grid-row")}
`) .appendTo(this.open_form_button) diff --git a/frappe/translations/fr.csv b/frappe/translations/fr.csv index af1210cb29..a3f8cb8733 100644 --- a/frappe/translations/fr.csv +++ b/frappe/translations/fr.csv @@ -4852,3 +4852,4 @@ Published on,Publié le, Bottom,Bas, Top,Haut, List View,Vue en liste, +Edit:edit-grid-row,Détail From dfe1990bf7aa37ebaf80a565089413f5ceb0c7b6 Mon Sep 17 00:00:00 2001 From: HENRY Florian Date: Fri, 29 Sep 2023 09:19:41 +0200 Subject: [PATCH 2/3] refactor: apply review Co-authored-by: Ankush Menat --- frappe/public/js/frappe/form/grid_row.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js index 505ac24c8b..15dd8f4fd1 100644 --- a/frappe/public/js/frappe/form/grid_row.js +++ b/frappe/public/js/frappe/form/grid_row.js @@ -338,7 +338,7 @@ export default class GridRow { this.open_form_button = $(`
${frappe.utils.icon("edit", "xs")} -
${__("Edit", "", "edit-grid-row")}
+
${__("Edit", "", "Edit grid row")}
`) .appendTo(this.open_form_button) From f04dd717c99bfe858048158c15b7417856d2ec50 Mon Sep 17 00:00:00 2001 From: HENRY Florian Date: Fri, 29 Sep 2023 09:19:50 +0200 Subject: [PATCH 3/3] refactor: apply review Co-authored-by: Ankush Menat --- frappe/translations/fr.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/translations/fr.csv b/frappe/translations/fr.csv index a3f8cb8733..5a2302acb3 100644 --- a/frappe/translations/fr.csv +++ b/frappe/translations/fr.csv @@ -4852,4 +4852,4 @@ Published on,Publié le, Bottom,Bas, Top,Haut, List View,Vue en liste, -Edit:edit-grid-row,Détail +Edit,Détail,Edit grid row,