From ed64dd728e9307152dbd694c858f3a4d82fe2fdc Mon Sep 17 00:00:00 2001 From: Hussain Nagaria Date: Wed, 1 Jan 2025 07:15:12 +0530 Subject: [PATCH] refactor: clean up long conditional --- frappe/public/js/frappe/model/create_new.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/frappe/public/js/frappe/model/create_new.js b/frappe/public/js/frappe/model/create_new.js index 38c617bc4b..018e840b42 100644 --- a/frappe/public/js/frappe/model/create_new.js +++ b/frappe/public/js/frappe/model/create_new.js @@ -290,13 +290,12 @@ $.extend(frappe.model, { // don't copy name and blank fields let df = frappe.meta.get_docfield(doc.doctype, key); - if ( - df && - key.substring(0, 2) != "__" && - !no_copy_list.includes(key) && - !(df && !from_amend && cint(df.no_copy) == 1) && - df.fieldtype !== "Password" - ) { + const is_internal_field = key.substring(0, 2) === "__"; + const is_blocked_field = no_copy_list.includes(key); + const is_no_copy = !from_amend && df && cint(df.no_copy) == 1; + const is_password = df && df.fieldtype === "Password"; + + if (df && !is_internal_field && !is_blocked_field && !is_no_copy && !is_password) { let value = doc[key] || []; if (frappe.model.table_fields.includes(df.fieldtype)) { for (let i = 0, j = value.length; i < j; i++) {