diff --git a/frappe/integrations/doctype/webhook/webhook.js b/frappe/integrations/doctype/webhook/webhook.js index 8154cf82a0..09c296113a 100644 --- a/frappe/integrations/doctype/webhook/webhook.js +++ b/frappe/integrations/doctype/webhook/webhook.js @@ -70,11 +70,7 @@ frappe.ui.form.on('Webhook', { enable_security: (frm) => { frm.toggle_reqd('webhook_secret', frm.doc.enable_security); - }, - - generate_secret: (frm) => { - frm.call("generate_secret"); - }, + } }); frappe.ui.form.on("Webhook Data", { diff --git a/frappe/integrations/doctype/webhook/webhook.json b/frappe/integrations/doctype/webhook/webhook.json index 4c02a4403e..9f979099c9 100644 --- a/frappe/integrations/doctype/webhook/webhook.json +++ b/frappe/integrations/doctype/webhook/webhook.json @@ -22,7 +22,6 @@ "sb_security", "enable_security", "webhook_secret", - "generate_secret", "sb_webhook_headers", "webhook_headers", "sb_webhook_data", @@ -148,16 +147,10 @@ "fieldname": "webhook_secret", "fieldtype": "Password", "label": "Webhook Secret" - }, - { - "depends_on": "eval:doc.enable_security == 1", - "fieldname": "generate_secret", - "fieldtype": "Button", - "label": "Generate Secret" } ], "links": [], - "modified": "2020-01-13 01:11:29.392078", + "modified": "2020-01-13 01:53:04.459968", "modified_by": "Administrator", "module": "Integrations", "name": "Webhook", diff --git a/frappe/integrations/doctype/webhook/webhook.py b/frappe/integrations/doctype/webhook/webhook.py index 070d0177b9..152ffada97 100644 --- a/frappe/integrations/doctype/webhook/webhook.py +++ b/frappe/integrations/doctype/webhook/webhook.py @@ -69,9 +69,6 @@ class Webhook(Document): if len(webhook_data) != len(set(webhook_data)): frappe.throw(_("Same Field is entered more than once")) - def generate_secret(self): - self.webhook_secret = frappe.generate_hash(length=32) - def get_context(doc): return {"doc": doc, "utils": frappe.utils}