From edac879d7e2b6061a2f79d423d585c7347327841 Mon Sep 17 00:00:00 2001
From: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Date: Thu, 4 Jan 2024 13:43:12 +0100
Subject: [PATCH] refactor!: remove unused parameter from rebuild_tree, add
 type hints (#24123)

* refactor!: remove unused parameter from rebuild_tree, add type hints

* fix: remove parent_field parameter from backend calls
---
 frappe/tests/test_nestedset.py |  2 +-
 frappe/utils/nestedset.py      | 10 +++-------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/frappe/tests/test_nestedset.py b/frappe/tests/test_nestedset.py
index 53304a5bb3..d308388646 100644
--- a/frappe/tests/test_nestedset.py
+++ b/frappe/tests/test_nestedset.py
@@ -145,7 +145,7 @@ class TestNestedSet(FrappeTestCase):
 		leaf_node.reload()
 
 	def test_rebuild_tree(self):
-		rebuild_tree(TEST_DOCTYPE, "parent_test_tree_doctype")
+		rebuild_tree(TEST_DOCTYPE)
 		self.test_basic_tree()
 
 	def test_move_group_into_another(self):
diff --git a/frappe/utils/nestedset.py b/frappe/utils/nestedset.py
index 59f68d7afc..60565581c9 100644
--- a/frappe/utils/nestedset.py
+++ b/frappe/utils/nestedset.py
@@ -168,12 +168,8 @@ def update_move_node(doc: Document, parent_field: str):
 
 
 @frappe.whitelist()
-def rebuild_tree(doctype, parent_field=None):
-	"""Call rebuild_node for all root nodes.
-
-	The `parent_field` parameter is ignored and will be removed in v16+ (kept for backward compatibility).
-	"""
-
+def rebuild_tree(doctype: str) -> None:
+	"""Call rebuild_node for all root nodes."""
 	# Check for perm if called from client-side
 	if frappe.request and frappe.local.form_dict.cmd == "rebuild_tree":
 		frappe.only_for("System Manager")
@@ -330,7 +326,7 @@ class NestedSet(Document):
 		)
 
 		if merge:
-			rebuild_tree(self.doctype, parent_field)
+			rebuild_tree(self.doctype)
 
 	def validate_one_root(self):
 		if not self.get(self.nsm_parent_field):