vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: set multiprocessing start mode to fork instead of forkserver

Browse source 
worker-pool with fork workers seem to not pick up jobs otherwise - the test `test_multi_queue_burst_consumption_worker_pool` just times out.

https://docs.python.org/3/whatsnew/3.14.html#concurrent-futures

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-11-03 13:04:40 +05:30
parent 6e20cde862
commit edc4b4bbd5
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frappe/utils/background_jobs.py
View file

@ -2,6 +2,7 @@ import os
import random
import signal
import socket
import sys
import time
from collections import defaultdict
from collections.abc import Callable
@ -373,6 +374,7 @@ class FrappeWorker(Worker):
def start_frappe_scheduler(self):
from frappe.utils.scheduler import start_scheduler
# TODO: switch to multiprocessing.Process() after further investigating of fork -> forkserver
Thread(target=start_scheduler, daemon=True).start()
@ -418,7 +420,6 @@ def start_worker_pool(
WARNING: This feature is considered "EXPERIMENTAL".
"""
_start_sentry()
# If gc.freeze is done then importing modules before forking allows us to share the memory
@ -447,9 +448,15 @@ def start_worker_pool(
logging_level = "WARNING"
# TODO: Make this true by default eventually. It's limited to RQ WorkerPool
no_fork = sbool(os.environ.get("FRAPPE_BACKGROUND_WORKERS_NOFORK", False))
if sbool(os.environ.get("FRAPPE_BACKGROUND_WORKERS_NOFORK", False)):
worker_klass = FrappeWorkerNoFork
else:
if sys.version_info >= (3, 14):
import multiprocessing
multiprocessing.set_start_method("fork", force=True)
worker_klass = FrappeWorker
worker_klass = FrappeWorkerNoFork if no_fork else FrappeWorker
pool = WorkerPool(
queues=queues,
connection=redis_connection,