vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat: use werkzeug send_file to allow range requests

Browse source
This commit is contained in:
Saqib Ansari 2025-09-03 11:30:19 +05:30
parent 495e166ba4
commit ee2c4c20ce
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
frappe/utils/response.py
View file

@ -19,7 +19,6 @@ import werkzeug.utils
from werkzeug.exceptions import Forbidden, NotFound
from werkzeug.local import LocalProxy
from werkzeug.wrappers import Response
from werkzeug.wsgi import wrap_file
import frappe
import frappe.model.document
@ -306,26 +305,26 @@ def send_private_file(path: str) -> Response:
response = Response()
response.headers["X-Accel-Redirect"] = quote(frappe.utils.encode(path))
response.headers["Cache-Control"] = "private,max-age=3600,stale-while-revalidate=86400"
response.headers["Accept-Ranges"] = "bytes"
else:
filepath = frappe.utils.get_site_path(path)
try:
f = open(filepath, "rb")
except OSError:
if not os.path.exists(filepath):
raise NotFound
response = Response(wrap_file(frappe.local.request.environ, f), direct_passthrough=True)
mimetype = mimetypes.guess_type(filename)[0] or "application/octet-stream"
# no need for content disposition and force download. let browser handle its opening.
# Except for those that can be injected with scripts.
extension = os.path.splitext(path)[1]
blacklist = [".svg", ".html", ".htm", ".xml"]
as_attachment = extension.lower() in blacklist
extension = os.path.splitext(path)[1]
blacklist = [".svg", ".html", ".htm", ".xml"]
send_kwargs = dict(mimetype=mimetype, conditional=True, as_attachment=as_attachment)
environ = frappe.local.request.environ
if extension.lower() in blacklist:
response.headers.add("Content-Disposition", "attachment", filename=filename)
response.mimetype = mimetypes.guess_type(filename)[0] or "application/octet-stream"
if as_attachment:
response = werkzeug.utils.send_file(filepath, environ, download_name=filename, **send_kwargs)
else:
response = werkzeug.utils.send_file(filepath, environ, **send_kwargs)
return response