From 00255a4c9e8e2829a15b27c1fe1a40bfbd9f95d0 Mon Sep 17 00:00:00 2001 From: Himanshu Date: Wed, 16 Dec 2020 17:40:18 +0530 Subject: [PATCH 1/2] fix: strip html before checking for null values Co-authored-by: Sahil Khan --- frappe/public/js/frappe/ui/field_group.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/field_group.js b/frappe/public/js/frappe/ui/field_group.js index d432e553f1..393f2af154 100644 --- a/frappe/public/js/frappe/ui/field_group.js +++ b/frappe/public/js/frappe/ui/field_group.js @@ -86,7 +86,7 @@ frappe.ui.FieldGroup = frappe.ui.form.Layout.extend({ var f = this.fields_dict[key]; if (f.get_value) { var v = f.get_value(); - if (f.df.reqd && is_null(v)) + if(f.df.reqd && is_null(strip_html(v))) errors.push(__(f.df.label)); if (f.df.reqd From 018e45fdcc9c73187ad27c6972376e75821aa4c9 Mon Sep 17 00:00:00 2001 From: sahil28297 <37302950+sahil28297@users.noreply.github.com> Date: Fri, 18 Dec 2020 00:13:49 +0530 Subject: [PATCH 2/2] chore: add space after if keyword --- frappe/public/js/frappe/ui/field_group.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/field_group.js b/frappe/public/js/frappe/ui/field_group.js index 393f2af154..67aeb4474e 100644 --- a/frappe/public/js/frappe/ui/field_group.js +++ b/frappe/public/js/frappe/ui/field_group.js @@ -86,7 +86,7 @@ frappe.ui.FieldGroup = frappe.ui.form.Layout.extend({ var f = this.fields_dict[key]; if (f.get_value) { var v = f.get_value(); - if(f.df.reqd && is_null(strip_html(v))) + if (f.df.reqd && is_null(strip_html(v))) errors.push(__(f.df.label)); if (f.df.reqd