From ee6743c26b5d8794486ca7b91c5ac28900fa60a0 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 18 Jan 2024 11:14:30 +0530 Subject: [PATCH] fix: avoid mutating list while iterating over it (#24438) --- frappe/commands/utils.py | 2 +- frappe/core/doctype/comment/comment.py | 2 +- frappe/desk/doctype/desktop_icon/desktop_icon.py | 2 +- frappe/desk/doctype/kanban_board/kanban_board.py | 2 +- frappe/utils/response.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frappe/commands/utils.py b/frappe/commands/utils.py index 8f6cb70d17..d8fcacbbda 100644 --- a/frappe/commands/utils.py +++ b/frappe/commands/utils.py @@ -601,7 +601,7 @@ def console(context, autoreload=False): all_apps = frappe.get_installed_apps() failed_to_import = [] - for app in all_apps: + for app in list(all_apps): try: locals()[app] = __import__(app) except ModuleNotFoundError: diff --git a/frappe/core/doctype/comment/comment.py b/frappe/core/doctype/comment/comment.py index 946f9833e1..b33b7e6f63 100644 --- a/frappe/core/doctype/comment/comment.py +++ b/frappe/core/doctype/comment/comment.py @@ -93,7 +93,7 @@ class Comment(Document): def remove_comment_from_cache(self): _comments = get_comments_from_parent(self) - for c in _comments: + for c in list(_comments): if c.get("name") == self.name: _comments.remove(c) diff --git a/frappe/desk/doctype/desktop_icon/desktop_icon.py b/frappe/desk/doctype/desktop_icon/desktop_icon.py index fda9eed7bb..1c3c2d1c86 100644 --- a/frappe/desk/doctype/desktop_icon/desktop_icon.py +++ b/frappe/desk/doctype/desktop_icon/desktop_icon.py @@ -271,7 +271,7 @@ def set_desktop_icons(visible_list, ignore_duplicate=True): frappe.db.sql("update `tabDesktop Icon` set blocked=0, hidden=1 where standard=1") # set as visible if present, or add icon - for module_name in visible_list: + for module_name in list(visible_list): name = frappe.db.get_value("Desktop Icon", {"module_name": module_name}) if name: frappe.db.set_value("Desktop Icon", name, "hidden", 0) diff --git a/frappe/desk/doctype/kanban_board/kanban_board.py b/frappe/desk/doctype/kanban_board/kanban_board.py index 4ab9e66f9d..49604f6cd0 100644 --- a/frappe/desk/doctype/kanban_board/kanban_board.py +++ b/frappe/desk/doctype/kanban_board/kanban_board.py @@ -238,7 +238,7 @@ def update_column_order(board_name, order): new_columns = [] for col in order: - for column in old_columns: + for column in list(old_columns): if col == column.column_name: new_columns.append(column) old_columns.remove(column) diff --git a/frappe/utils/response.py b/frappe/utils/response.py index 448d43a456..9fe10545d1 100644 --- a/frappe/utils/response.py +++ b/frappe/utils/response.py @@ -61,7 +61,7 @@ def report_error(status_code): def _link_error_with_message_log(error_log, exception, message_logs): - for message in message_logs: + for message in list(message_logs): if message.get("__frappe_exc_id") == getattr(exception, "__frappe_exc_id", None): error_log.update(message) message_logs.remove(message)