From ef4f7a91f7ca2e7d5b7c8de598fb2ec35c11d287 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 10 Apr 2020 11:46:14 +0530 Subject: [PATCH] fix: label not updating bug --- frappe/public/js/frappe/widgets/widget_dialog.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/frappe/public/js/frappe/widgets/widget_dialog.js b/frappe/public/js/frappe/widgets/widget_dialog.js index ee6376982d..eb1310d42c 100644 --- a/frappe/public/js/frappe/widgets/widget_dialog.js +++ b/frappe/public/js/frappe/widgets/widget_dialog.js @@ -85,12 +85,7 @@ class ChartDialog extends WidgetDialog { } process_data(data) { - if (this.values && this.values.label) { - data.label = this.values.label; - } else { - data.label = data.chart_name; - } - + data.label = data.label ? data.label : data.chart_name return data } } @@ -206,11 +201,7 @@ class ShortcutDialog extends WidgetDialog { data.stats_filter = JSON.stringify(stats_filter); } - if (this.values && this.values.label) { - data.label = this.values.label; - } else { - data.label = data.link_to; - } + data.label = data.link_to return data }