vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #31290 from akhilnarang/fix-reportview-edit-if-has-table

Browse source 
fix(report_view): don't disallow editing just if a table exists
This commit is contained in:
Akhil Narang 2025-02-18 11:24:48 +05:30 • committed by GitHub
commit ef4ffbb304
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/public/js/frappe/views/reports/report_view.js
View file

@ -702,7 +702,7 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
}
is_editable(df, data) {
return (
if (
df &&
frappe.model.can_write(this.doctype) &&
// not a submitted doc or field is allowed to edit after submit
@ -713,12 +713,16 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
!df.is_virtual &&
!df.hidden &&
// not a standard field i.e., owner, modified_by, etc.
frappe.model.is_non_std_field(df.fieldname) &&
frappe.model.is_non_std_field(df.fieldname)
) {
// don't check read_only_depends_on if there's child table fields
!this.meta.fields.some((df) => df.fieldtype === "Table") &&
df.read_only_depends_on &&
!this.evaluate_read_only_depends_on(df.read_only_depends_on, data)
);
return (
this.meta.fields.some((df) => df.fieldtype === "Table") ||
(df.read_only_depends_on &&
!this.evaluate_read_only_depends_on(df.read_only_depends_on, data))
);
}
return false;
}
get_data(values) {