From 94fefa31a8314cb8386f7018746c762e041e43e0 Mon Sep 17 00:00:00 2001 From: tonspar <121026420+tonspar@users.noreply.github.com> Date: Tue, 27 Feb 2024 09:40:34 +0100 Subject: [PATCH 1/2] Avoid add "null" to cc --- frappe/public/js/frappe/form/footer/form_timeline.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/footer/form_timeline.js b/frappe/public/js/frappe/form/footer/form_timeline.js index 57acf85f7c..08f9c89346 100644 --- a/frappe/public/js/frappe/form/footer/form_timeline.js +++ b/frappe/public/js/frappe/form/footer/form_timeline.js @@ -575,7 +575,7 @@ class FormTimeline extends BaseTimeline { } if (reply_all) { // if reply_all then add cc and bcc as well. - args.cc += communication_doc.cc; + args.cc += (communication_doc.cc || ""); args.bcc = communication_doc.bcc; } } From 2f6ec63447b95132385e0b5e2e50caf214cb3994 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 27 Feb 2024 14:44:21 +0530 Subject: [PATCH 2/2] chore: extend fix to BCC --- frappe/public/js/frappe/form/footer/form_timeline.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/form/footer/form_timeline.js b/frappe/public/js/frappe/form/footer/form_timeline.js index 08f9c89346..2d27fe12c3 100644 --- a/frappe/public/js/frappe/form/footer/form_timeline.js +++ b/frappe/public/js/frappe/form/footer/form_timeline.js @@ -575,8 +575,8 @@ class FormTimeline extends BaseTimeline { } if (reply_all) { // if reply_all then add cc and bcc as well. - args.cc += (communication_doc.cc || ""); - args.bcc = communication_doc.bcc; + args.cc += cstr(communication_doc.cc); + args.bcc = cstr(communication_doc.bcc); } }