vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(ListView): In ListView make visible link title value for Subject column (#25569)

Browse source 
* fix(ListView): In ListView make visible link tite value for Subject column

Fixes #25567

* Revert "fix(ListView): In ListView make visible link tite value for Subject column"

This reverts commit eea3ea0a148f6f5800f1b008f97f8a86b4e6ebe8.

* fix: show title in subject field

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
This commit is contained in:
Maxim Sysoev 2024-03-30 07:53:01 +02:00 • committed by GitHub
parent ea5e1b61ad
commit f32c3aa3a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/public/js/frappe/list/list_view.js
View file

@ -877,7 +877,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
column_html = this.settings.formatters[fieldname](value, df, doc);
} else {
column_html = {
Subject: this.get_subject_element(doc).innerHTML,
Subject: this.get_subject_element(doc, value_display).innerHTML,
Field: field_html(),
}[col.type];
}
@ -1025,7 +1025,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
return div.innerHTML;
}
get_subject_element(doc) {
get_subject_element(doc, title) {
const ef = this._element_factory;
const div = document.createElement("div");
const checkboxspan = ef.get_checkboxspan_element();
@ -1038,15 +1038,19 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
div.appendChild(checkboxspan).appendChild(ef.get_checkbox_element(doc.name));
div.appendChild(ellipsisSpan).appendChild(
ef.get_link_element(doc.name, this.get_form_link(doc), this.get_subject_text(doc))
ef.get_link_element(
doc.name,
this.get_form_link(doc),
this.get_subject_text(doc, title)
)
);
return div;
}
get_subject_text(doc) {
get_subject_text(doc, title) {
const subject_field = this.columns[0].df;
let value = doc[subject_field.fieldname];
let value = title || doc[subject_field.fieldname];
if (this.settings.formatters && this.settings.formatters[subject_field.fieldname]) {
let formatter = this.settings.formatters[subject_field.fieldname];
value = formatter(value, subject_field, doc);