From f49d7cf53c813d63b73a24d6a2206205de5c997c Mon Sep 17 00:00:00 2001 From: sokumon Date: Fri, 14 Nov 2025 08:51:37 +0530 Subject: [PATCH] fix: grid search test and semgrep --- cypress/integration/grid_search.js | 4 ++-- frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py | 4 +++- frappe/public/scss/common/grid.scss | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cypress/integration/grid_search.js b/cypress/integration/grid_search.js index d8d39d616f..66364501a6 100644 --- a/cypress/integration/grid_search.js +++ b/cypress/integration/grid_search.js @@ -40,7 +40,7 @@ context("Grid Search", () => { }); }); - cy.visit(`/app/doctype-with-child-table/Test Grid Search`); + cy.visit(`/desk/doctype-with-child-table/Test Grid Search`); cy.get('.frappe-control[data-fieldname="child_table_1"]').as("table"); cy.get("@table").find(".grid-row-check:last").click(); @@ -49,7 +49,7 @@ context("Grid Search", () => { }); it("test search field for different fieldtypes", () => { - cy.visit(`/app/doctype-with-child-table/Test Grid Search`); + cy.visit(`/desk/doctype-with-child-table/Test Grid Search`); cy.get('.frappe-control[data-fieldname="child_table_1"]').as("table"); diff --git a/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py b/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py index 478ab49eaf..d7476e6292 100644 --- a/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py +++ b/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py @@ -101,6 +101,8 @@ def is_workspace_manager(): def create_workspace_sidebar_for_workspaces(): + import click + from frappe.query_builder import DocType workspace = DocType("Workspace") @@ -118,7 +120,7 @@ def create_workspace_sidebar_for_workspaces(): sidebar = frappe.new_doc("Workspace Sidebar") sidebar.title = workspace sidebar.header_icon = frappe.db.get_value("Workspace", workspace, "icon") - print("Creating Sidebar Items for", workspace) + click.echo("Creating Sidebar Items for", workspace) shortcuts = workspace_doc.shortcuts items = [] diff --git a/frappe/public/scss/common/grid.scss b/frappe/public/scss/common/grid.scss index 46ec763785..5d5636d1f6 100644 --- a/frappe/public/scss/common/grid.scss +++ b/frappe/public/scss/common/grid.scss @@ -58,6 +58,7 @@ .grid-static-col, .row-check, .row-index { + height: 32px; padding: 4px 8px !important; background-color: var(--subtle-fg); } @@ -686,7 +687,6 @@ &:focus-visible { @include grid-focus(); } - .grid-static-col.col-xs-1 { flex: 1 0 60px; width: 60px;