From f50be4bbf5ae9396dabf3e5e31ed1e40e9fcf8d9 Mon Sep 17 00:00:00 2001 From: phot0n Date: Sun, 1 Jan 2023 23:00:03 +0530 Subject: [PATCH] chore: log any exception while refreshing access token in connected apps --- .../doctype/connected_app/connected_app.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/frappe/integrations/doctype/connected_app/connected_app.py b/frappe/integrations/doctype/connected_app/connected_app.py index e8193c89f2..ff2eb2dc96 100644 --- a/frappe/integrations/doctype/connected_app/connected_app.py +++ b/frappe/integrations/doctype/connected_app/connected_app.py @@ -107,11 +107,17 @@ class ConnectedApp(Document): token_cache = self.get_token_cache(user) if token_cache and token_cache.is_expired(): oauth_session = self.get_oauth2_session(user) - token = oauth_session.refresh_token( - body=f"redirect_uri={self.redirect_uri}", - token_url=self.token_uri, - refresh_token=token_cache.get_password("refresh_token"), - ) + + try: + token = oauth_session.refresh_token( + body=f"redirect_uri={self.redirect_uri}", + token_url=self.token_uri, + refresh_token=token_cache.get_password("refresh_token"), + ) + except Exception: + self.log_error("Token Refresh Error") + return None + token_cache.update_data(token) return token_cache