vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: Remove unnecessary code in query_report

Browse source 
get_user_settings is useless after following refactor
https://github.com/frappe/frappe/pull/5473
https://github.com/frappe/frappe/pull/5834

53193d3130
This commit is contained in:
Suraj Shetty 2020-04-04 19:09:06 +05:30
parent ab6d6f3f65
commit f51c975759
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/public/js/frappe/views/reports/query_report.js
View file

@ -242,7 +242,6 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
() => this.setup_filters(),
() => this.set_route_filters(),
() => this.report_settings.onload && this.report_settings.onload(this),
() => this.get_user_settings(),
() => this.refresh()
]);
}
@ -850,13 +849,6 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
setTimeout(preview_chart, 500);
}
get_user_settings() {
return frappe.model.user_settings.get(this.report_name)
.then(user_settings => {
this.user_settings = user_settings;
});
}
prepare_columns(columns) {
return columns.map(column => {
column = frappe.report_utils.prepare_field_from_column(column);