From f5a45a7e788f0df2507727443fe71a836ee03519 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sat, 10 Sep 2022 13:01:24 +0530 Subject: [PATCH] fix: erase default before adding new series-es --- .github/workflows/server-mariadb-tests.yml | 1 - .../document_naming_settings/document_naming_settings.py | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/server-mariadb-tests.yml b/.github/workflows/server-mariadb-tests.yml index 1eab828ffb..7a38648e63 100644 --- a/.github/workflows/server-mariadb-tests.yml +++ b/.github/workflows/server-mariadb-tests.yml @@ -74,7 +74,6 @@ jobs: fi - uses: actions/setup-node@v3 - if: ${{ steps.check-build.outputs.build == 'strawberry' }} with: node-version: 16 check-latest: true diff --git a/frappe/core/doctype/document_naming_settings/document_naming_settings.py b/frappe/core/doctype/document_naming_settings/document_naming_settings.py index 6fc4d9b23e..0cdba32dae 100644 --- a/frappe/core/doctype/document_naming_settings/document_naming_settings.py +++ b/frappe/core/doctype/document_naming_settings/document_naming_settings.py @@ -113,6 +113,8 @@ class DocumentNamingSettings(Document): option_string = "\n".join(options) + # Erase default first, it might not be in new options. + self.update_naming_series_property_setter(doctype, "default", "") self.update_naming_series_property_setter(doctype, "options", option_string) self.update_naming_series_property_setter(doctype, "default", default)