vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: roles getting re-inserted on every save

Browse source
This commit is contained in:
Ankush Menat 2024-02-10 11:28:15 +05:30
parent 72b40135ce
commit f609025472
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
frappe/core/doctype/user/user.py
View file

@ -178,13 +178,17 @@ class User(Document):
self.set_social_login_userid("frappe", frappe.generate_hash(length=39))
def populate_role_profile_roles(self):
roles = set()
if self.role_profiles:
for role_profile in self.role_profiles:
role_profile = frappe.get_cached_doc("Role Profile", role_profile.role_profile)
roles.update(role.role for role in role_profile.roles)
self.set("roles", [])
self.append_roles(*roles)
if not self.role_profiles:
return
new_roles = set()
for role_profile in self.role_profiles:
role_profile = frappe.get_cached_doc("Role Profile", role_profile.role_profile)
new_roles.update(role.role for role in role_profile.roles)
# Remove invalid roles and add new ones
self.roles = [r for r in self.roles if r.role in new_roles]
self.append_roles(*new_roles)
@deprecated
def validate_roles(self):