vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: Remove unused empty table checks (#35469)

Browse source
This commit is contained in:
Ankush Menat 2025-12-29 12:58:41 +05:30 • committed by GitHub
parent db4e834837
commit f6873fec0a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
frappe/utils/modules.py
View file

@ -11,15 +11,6 @@ def get_modules_from_all_apps_for_user(user: str | None = None) -> list[dict]:
blocked_modules = global_blocked_modules + user_blocked_modules
allowed_modules_list = [m for m in all_modules if m.get("module_name") not in blocked_modules]
empty_tables_by_module = get_all_empty_tables_by_module()
for module in allowed_modules_list:
module_name = module.get("module_name")
# Apply onboarding status
if module_name in empty_tables_by_module:
module["onboard_present"] = 1
return allowed_modules_list
@ -35,29 +26,6 @@ def get_modules_from_app(app):
return frappe.get_all("Module Def", filters={"app_name": app}, fields=["module_name", "app_name as app"])
def get_all_empty_tables_by_module():
table_rows = frappe.qb.Field("table_rows")
table_name = frappe.qb.Field("table_name")
information_schema = frappe.qb.Schema("information_schema")
empty_tables = (
frappe.qb.from_(information_schema.tables).select(table_name).where(table_rows == 0)
).run()
empty_tables = {r[0] for r in empty_tables}
results = frappe.get_all("DocType", fields=["name", "module"])
empty_tables_by_module = {}
for doctype, module in results:
if f"tab{doctype}" in empty_tables:
if module in empty_tables_by_module:
empty_tables_by_module[module].append(doctype)
else:
empty_tables_by_module[module] = [doctype]
return empty_tables_by_module
def is_domain(module):
return module.get("category") == "Domains"