From cbb277dd62505c3625765c4eb80843ef7a543a7d Mon Sep 17 00:00:00 2001
From: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
Date: Thu, 8 Jan 2026 13:16:09 +0530
Subject: [PATCH 1/2] fix: check for config when allowing `Toggle All Private`

---
 frappe/public/js/frappe/file_uploader/FilePreview.vue    | 7 -------
 .../js/frappe/file_uploader/file_uploader.bundle.js      | 9 ++++++++-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/frappe/public/js/frappe/file_uploader/FilePreview.vue b/frappe/public/js/frappe/file_uploader/FilePreview.vue
index 97dae5c9c2..22a7fd1fbe 100644
--- a/frappe/public/js/frappe/file_uploader/FilePreview.vue
+++ b/frappe/public/js/frappe/file_uploader/FilePreview.vue
@@ -138,13 +138,6 @@ let allow_toggle_optimize = computed(() => {
 	);
 });
 
-let allow_toggle_private = computed(() => {
-	if (!frappe.utils.can_upload_public_files()) {
-		return false;
-	}
-	return props.allow_toggle_private;
-});
-
 let show_private_checkbox = computed(() => {
 	return !uploaded.value && !props.file.failed;
 });
diff --git a/frappe/public/js/frappe/file_uploader/file_uploader.bundle.js b/frappe/public/js/frappe/file_uploader/file_uploader.bundle.js
index 03c1a53132..44e9d9add6 100644
--- a/frappe/public/js/frappe/file_uploader/file_uploader.bundle.js
+++ b/frappe/public/js/frappe/file_uploader/file_uploader.bundle.js
@@ -30,7 +30,14 @@ class FileUploader {
 	} = {}) {
 		frm && frm.attachments.max_reached(true);
 
-		this.can_toggle_private = frappe.utils.can_upload_public_files();
+		if (allow_toggle_private === undefined) {
+			allow_toggle_private = true;
+		}
+
+		allow_toggle_private = Boolean(
+			allow_toggle_private && frappe.utils.can_upload_public_files()
+		);
+		this.can_toggle_private = allow_toggle_private;
 
 		if (!wrapper) {
 			this.make_dialog(dialog_title);

From aa8210a6fee522bdeaaf26ab8b7edc4b6e5763e5 Mon Sep 17 00:00:00 2001
From: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
Date: Thu, 8 Jan 2026 13:17:55 +0530
Subject: [PATCH 2/2] fix: ignore warnings when running cypress

---
 frappe/commands/testing.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/frappe/commands/testing.py b/frappe/commands/testing.py
index 4faf1d999f..d1381671b2 100644
--- a/frappe/commands/testing.py
+++ b/frappe/commands/testing.py
@@ -465,7 +465,13 @@ def run_ui_tests(
 
 	os.chdir(app_base_path)
 
-	node_bin = subprocess.getoutput("(cd ../frappe && yarn bin)")
+	node_bin = subprocess.run(
+		"(cd ../frappe && yarn bin)",
+		shell=True,
+		stdout=subprocess.PIPE,
+		stderr=subprocess.DEVNULL,
+		text=True,
+	).stdout.strip()
 	cypress_path = f"{node_bin}/cypress"
 	drag_drop_plugin_path = f"{node_bin}/../@4tw/cypress-drag-drop"
 	real_events_plugin_path = f"{node_bin}/../cypress-real-events"