From 791b2374c5f790d815ec9a8b556ebf527b2e7cee Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Thu, 21 Aug 2014 18:36:05 +0530 Subject: [PATCH 1/2] dont allow to edit read only fields through report view --- frappe/client.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/client.py b/frappe/client.py index ea7519894e..9d7312dfce 100644 --- a/frappe/client.py +++ b/frappe/client.py @@ -42,7 +42,11 @@ def set_value(doctype, name, fieldname, value): child.set(fieldname, value) else: doc = frappe.get_doc(doctype, name) - doc.set(fieldname, value) + df = doc.meta.get_field(fieldname) + if df.fieldtype == "Read Only" or df.read_only: + frappe.throw(_("Can not edit Read Only fields")) + else: + doc.set(fieldname, value) doc.save() From 0f83f0d2147b802f22d33dc6f6897451729e265d Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 22 Aug 2014 14:08:47 +0530 Subject: [PATCH 2/2] Fixes in breadcrumbs template --- frappe/templates/includes/breadcrumbs.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/templates/includes/breadcrumbs.html b/frappe/templates/includes/breadcrumbs.html index 01e1162ac6..3303f44677 100644 --- a/frappe/templates/includes/breadcrumbs.html +++ b/frappe/templates/includes/breadcrumbs.html @@ -1,4 +1,4 @@ -{% set parents = doc.get_parents() if doc else [] %} +{% set parents = doc.get_parents() if (doc and hasattr(doc, "get_parents")) else [] %}