vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #38047 from Priyal208/select-read-perm

Browse source
This commit is contained in:
Sagar Vora 2026-03-17 12:58:54 +00:00 • committed by GitHub
commit f72d7b0437
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/client.py
View file

@ -472,7 +472,7 @@ def validate_link_and_fetch(
if is_virtual_dt:
try:
doc = frappe.get_doc(doctype, docname)
doc.check_permission("select" if frappe.only_has_select_perm(doctype) else "read")
doc.check_permission("select")
values = {"name": doc.name}
except frappe.DoesNotExistError:

19
frappe/database/query.py
View file

@ -274,7 +274,7 @@ class Engine:
self.table = qb.DocType(table)
if self.apply_permissions:
self.check_read_permission()
self.check_select_permission()
self.permission_doctype = parent_doctype or self.doctype
self.permission_table = (
qb.DocType(self.permission_doctype) if self.permission_doctype != self.doctype else self.table
@ -1404,18 +1404,11 @@ class Engine:
return parsed_order_fields
def check_read_permission(self):
"""Check if user has read permission on the doctype"""
def has_permission(ptype):
return frappe.has_permission(
self.doctype,
ptype,
user=self.user,
parent_doctype=self.parent_doctype,
)
if not has_permission("select") and not has_permission("read"):
def check_select_permission(self):
"""Check if user has select (or read) permission on the doctype"""
if not frappe.has_permission(
self.doctype, "select", user=self.user, parent_doctype=self.parent_doctype
):
self._raise_permission_error()
def _raise_permission_error(self, doctype=None):