vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Don't serve local cache values when it becomes unhealthy

Browse source
This commit is contained in:
Ankush Menat 2025-01-06 13:57:54 +05:30
parent 29733febcb
commit f74ada155e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/utils/redis_wrapper.py
View file

@ -428,13 +428,14 @@ class _ClientCache:
frappe.throw("RESP3 is not supported while connecting to Redis.")
self.invalidator_thread = self.run_invalidator_thread()
self.local_cache: dict[bytes, _ClientCacheValue] = {}
self.cache_healthy = True
self._conn_retries = 0
def get_value(self, key):
key = self.redis.make_key(key)
try:
val = self.local_cache[key]
if time.monotonic() < val[1]:
if time.monotonic() < val[1] and self.cache_healthy:
return val[0]
else:
self.local_cache.pop(key, None) # expired
@ -488,9 +489,11 @@ class _ClientCache:
self.local_cache.clear()
self._conn_retries += 1
if self._conn_retries > 10:
self.cache_healthy = False
raise
time.sleep(1)
else:
self.cache_healthy = False
raise
def clear_cache(self):