vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Apply suggestions from code review

Browse source 
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
This commit is contained in:
Shariq Ansari 2021-08-30 13:31:07 +05:30 • committed by GitHub
parent 4f31f9c501
commit f84344592a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/public/js/frappe/list/list_view.js
View file

@ -952,11 +952,16 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
get_indicator_html(doc) {
const indicator = frappe.get_indicator(doc, this.doctype);
const title = doc.docstatus == 1 ? 'Document has been submitted' : doc.docstatus == 2 ?
'Document has been cancelled' : 'Document is in draft state';
// sequence is important
const docstatus_description = [
__('Document is in draft state'),
__('Document has been submitted'),
__('Document has been cancelled')
]
const title = docstatus_description[doc.docstatus || 0]
if (indicator) {
return `<span class="indicator-pill ${indicator[1]} filterable ellipsis"
data-filter='${indicator[2]}' title='${__(title)}'>
data-filter='${indicator[2]}' title='${title}'>
<span class="ellipsis"> ${__(indicator[0])}</span>
<span>`;
}