From f8443020ca8e314c718f3003e9ebe4ee9f5b948d Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Mon, 5 Jan 2026 12:11:16 +0530 Subject: [PATCH] fix(error): don't return in a finally block (PEP-765) (#35610) https://docs.python.org/3/whatsnew/3.14.html#pep-765-control-flow-in-finally-blocks Signed-off-by: Akhil Narang --- frappe/utils/error.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/utils/error.py b/frappe/utils/error.py index deed1deb34..3a424eff5d 100644 --- a/frappe/utils/error.py +++ b/frappe/utils/error.py @@ -109,9 +109,10 @@ def get_error_metadata() -> str: metadata["form_dict"] = sanitized_dict(frappe.form_dict) metadata["user"] = getattr(frappe.session, "user", "Unidentified") - finally: + except Exception: # We don't want to bother with exception handling *while* gathering some error's metadata - return frappe.as_json(metadata) # noqa: B012 + pass + return frappe.as_json(metadata) def log_error_snapshot(exception: Exception):