From f88df828207fa431a4446b8711c467b455a992c4 Mon Sep 17 00:00:00 2001 From: Corentin Flr <10946971+cogk@users.noreply.github.com> Date: Sat, 2 Sep 2023 07:52:33 +0200 Subject: [PATCH] chore(rq): Pass `rq.Callback` objects to `enqueue_call` (#22271) > DeprecationWarning: Passing a string or function for `on_failure` is deprecated, pass `Callback` instead --- frappe/utils/background_jobs.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/utils/background_jobs.py b/frappe/utils/background_jobs.py index 116f08911d..7dcd33014e 100755 --- a/frappe/utils/background_jobs.py +++ b/frappe/utils/background_jobs.py @@ -10,7 +10,7 @@ from uuid import uuid4 import redis from redis.exceptions import BusyLoadingError, ConnectionError -from rq import Queue, Worker +from rq import Callback, Queue, Worker from rq.exceptions import NoSuchJobError from rq.job import Job, JobStatus from rq.logutils import setup_loghandlers @@ -145,8 +145,8 @@ def enqueue( def enqueue_call(): return q.enqueue_call( execute_job, - on_success=on_success, - on_failure=on_failure, + on_success=Callback(func=on_success) if on_success else None, + on_failure=Callback(func=on_failure) if on_failure else None, timeout=timeout, kwargs=queue_args, at_front=at_front,